type checking and error handling for builtins improved.
Some checks failed
Build / build (push) Successful in 11m16s
Test / build (push) Failing after 17m0s

This commit is contained in:
Chuck Smith
2024-03-25 16:18:08 -04:00
parent 1c99d2198b
commit 6d234099d1
52 changed files with 650 additions and 433 deletions

View File

@@ -1,23 +1,25 @@
package builtins
import "monkey/object"
import (
"monkey/object"
"monkey/typing"
)
// Pop ...
func Pop(args ...object.Object) object.Object {
if len(args) != 1 {
return newError("wrong number of arguments. got=%d, want=1",
len(args))
}
if args[0].Type() != object.ARRAY_OBJ {
return newError("argument to `pop` must be array, got %s",
args[0].Type())
if err := typing.Check(
"pop", args,
typing.ExactArgs(1),
typing.WithTypes(object.ARRAY_OBJ),
); err != nil {
return newError(err.Error())
}
arr := args[0].(*object.Array)
length := len(arr.Elements)
if length == 0 {
return newError("cannot pop from an empty array")
return newError("IndexError: pop from an empty array")
}
element := arr.Elements[length-1]